This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Update nginx-proxy to latest upstream, support multiple architectures#22
Open
dustinrue wants to merge 3 commits into10up:masterfrom
Open
Update nginx-proxy to latest upstream, support multiple architectures#22dustinrue wants to merge 3 commits into10up:masterfrom
dustinrue wants to merge 3 commits into10up:masterfrom
Conversation
Author
|
This PR would close #21 |
eugene-manuilov
suggested changes
Jun 3, 2021
| @@ -1,4 +1,4 @@ | |||
| FROM jwilder/nginx-proxy:0.7.0 | |||
| FROM nginxproxy/nginx-proxy:latest | |||
Collaborator
There was a problem hiding this comment.
@dustinrue jwilder/nginx-proxy also supports arm based systems now:
Looks like we don't need to switch to nginxproxy/nginx-proxy anymore, do we? We just need to update the tag of the jwilder/nginx-proxy image. I think we can even update it to the alpine tag which is 3 times smaller than the latest one. What do you think?
Suggested change
| FROM nginxproxy/nginx-proxy:latest | |
| FROM jwilder/nginx-proxy:alpine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Checklist:
Applicable Issues
Changelog Entry